Use theforeman-rubocop gem #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Apr 5, 2024
archanaserver
force-pushed
the
rubocop
branch
2 times, most recently
from
104aeae
to
1ae3363
Compare
|
The failure is due to the Ruby v2.2 but I'm not sure from where it is coming, can you help me here @ekohl? |
evgeni
reviewed
Jul 11, 2024
archanaserver
force-pushed
the
rubocop
branch
2 times, most recently
from
3149db3
to
b3fce39
Compare
evgeni
reviewed
Jul 22, 2024
.rubocop.yml
Outdated
| - rubocop-minitest | ||
| inherit_gem: | ||
| theforeman-rubocop: | ||
| - strictest.yml |
There was a problem hiding this comment.
Should we really use strictest given the amount of todo it generated?
There was a problem hiding this comment.
@evgeni not sure why i used that earlier, but now with default we have less cops in todo as compared to what we have earlier.
Inherited strictest.yml here, because this closely matches with what rules we already have in our rubocop.yml config. Also dropped Rails, Style/HashSyntax, Style/Documentation and Style/SymbolArray from here because that was included in the inherited file.
|
@evgeni i have made some changes, can you take a look? |
|
@archanaserver looks reasonable to me @nofaralfasi any last words on this? or shall I just hit he button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherited strictest.yml here, because this closely matches with what rules we already have in our .rubocop.yml config. Also dropped Rails, Style/HashSyntax, Style/Documentation and Style/SymbolArray from here because that was included in the inherited file.
This is part of RuboCop standardization, link for the reference:
https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239
https://github.com/theforeman/theforeman-rubocop/?tab=readme-ov-file#all-opinionated-cops-with-new-ones---strictest