Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #32693 - Fix Grammar and update screenshots on README #128

Merged
merged 1 commit into from Jun 8, 2021
Merged

Fixes #32693 - Fix Grammar and update screenshots on README #128

merged 1 commit into from Jun 8, 2021

Conversation

chris1984
Copy link
Member

No description provided.

@chris1984 chris1984 changed the title Fixes #32693 - Fix Grammer and update screenshots on README Fixes #32693 - Fix Grammar and update screenshots on README Jun 1, 2021
upadhyeammit
upadhyeammit reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@upadhyeammit upadhyeammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker however for both image changes I feel we need to reduce the resolution of monitor while taking screenshots as text on the images is not readable and I need to zoom it if I open those from laptop screen.

@chris1984 chris1984 merged commit fc279f0 into theforeman:master Jun 8, 2021
@chris1984 chris1984 deleted the update-docs branch June 8, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upadhyeammit upadhyeammit upadhyeammit left review comments

Assignees
No one assigned
Labels
Ready for Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris1984 @upadhyeammit @theforeman-bot