Fixes #28438 - Undefined method reload for PowerOn/Off #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apuntamb
commented
Dec 6, 2019
| @@ -44,6 +44,9 @@ def ready? | |||
| vm_status == 'running' | |||
| end | |||
|
|
|||
| def reload | |||
| end | |||
There was a problem hiding this comment.
@ShimShtein Introducing this method in our wrapper class, solves the error for us since it finds the method definition. But, I'm not very sure of what should be returned here?
There was a problem hiding this comment.
#reload method does not need any return value.
There was a problem hiding this comment.
The vm is reloaded for getting the new power state to show in the UI. In our case, we load the power state from SDK each access to vm_status method, it can remain blank.
|
Merged, thanks @apuntamb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.