fixes #25120 - use medium provider interface #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes use of the new medium provider interface to build the full host image as the old way of calling the methods is deprecated and will be removed in 1.22.
The embedded PXElinux template is now rendered in it's own template scope (yay, new renderer!) so we can avoid ugly
gsub
string replacement hacks.This also prepares foreman_bootdisk for frozen strings.
And all of this removes this loop, which is very hard to digest:
foreman_bootdisk/app/services/foreman_bootdisk/iso_generator.rb
Lines 23 to 31 in 15ed6d9