Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14797 - remove media presence check #73

Merged
merged 1 commit into from Jan 21, 2019

Conversation

lzap
Copy link
Member

@lzap lzap commented Jan 9, 2019

Bootdisk counterpart for theforeman/foreman#6331

Copy link
Member

@timogoebel timogoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if the core PR is merged.

@lzap: Please update the minimum required Foreman version in engine.rb as well.

@lzap
Copy link
Member Author

lzap commented Jan 21, 2019

[test] or [test bootdisk] or [test foreman_bootdisk] not sure
green locally

@timogoebel
Copy link
Member

@lzap: Don't forget to update the minimum required version in engine.rb.

@lzap lzap force-pushed the media-presence-final-14797 branch from ef7d2f9 to bc80c3d Compare January 21, 2019 09:44
@lzap
Copy link
Member Author

lzap commented Jan 21, 2019

Done, all good.

@timogoebel timogoebel merged commit 1e24194 into theforeman:master Jan 21, 2019
@lzap lzap deleted the media-presence-final-14797 branch April 10, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants