This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
fixes #11308 - don't use deprecated proxy scope #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| # Global parameters used in configuration snippets | |||
| parameters = [ | |||
| { :name => 'chef_handler_foreman_url', :value => SmartProxy.chef_proxies.first.try(:url) || Setting.foreman_url }, | |||
| { :name => 'chef_handler_foreman_url', :value => SmartProxy.with_features('chef').first.try(:url) || Setting.foreman_url }, | |||
|
This change will be compatible with Foreman 1.5+, we just have to release new version which will make it to 1.9 repo. The linked PR will need the bump for sure but I was thinking about 0.2, 1.0.0 would sound too stable. |
|
Thanks @mmoll, merging! |
ares
added a commit
that referenced
this pull request
Aug 10, 2015
fixes #11308 - don't use deprecated proxy scope
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe merge together with #24 and bump the version to 1.0.0 because of Foreman version dependencies.