This repository has been archived by the owner on Sep 18, 2018. It is now read-only.
Add supports for pulp notification callbacks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,25 @@ | |||
| class Content::PulpEventHandler | |||
There was a problem hiding this comment.
Is this class simply being used to log when we receive a notification from Pulp or does it have future intended uses? Can we put non-AR objects either in a sub-directory or app/lib ?
There was a problem hiding this comment.
the idea is to use this as a starting point, to get sync notifications, to update the last sync state etc (if we want to cache it / save it in the AR object etc).
afaik, the best practice for files like these should be in app/services, if that makes more sense we can move it?
* adds /api/repositories/events POST action * adds PulpEventHandler class to parse and act on the events. * adds an option to auto register events on pulp, this however is dead code at the moment since i would assume the workflow will change once we have multi-pulp support to register notifications (in the meanwhile) manually on your pulp server execute: pulp-admin event listener http create
|
@ehelms updated |
|
ACK |
|
merged as 0d17965 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the moment since i would assume the workflow will change once we have
multi-pulp support
to register notifications (in the meanwhile) manually on your pulp
server execute:
pulp-admin event listener http create