Fixes #21446 - adjust to rubocop v0.51.0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNecas
reviewed
Oct 25, 2017
| @@ -1,4 +1,3 @@ | |||
| require 'thread' | |||
There was a problem hiding this comment.
Disabled Lint/UnneededRequireStatement: in .rubocop.yml
There was a problem hiding this comment.
What about disabling it just here, with a comment on why?
There was a problem hiding this comment.
Yeah, I tried that actually but rubocop is complaining about it saying Unnecessary disabling of Lint/UnneededRequireStatement
Offenses:
lib/foreman_maintain/reporter/cli_reporter.rb:1:18: W: Unnecessary disabling of Lint/UnneededRequireStatement.
require 'thread' # rubocop:disable Lint/UnneededRequireStatement
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
157 files inspected, 1 offense detected
RuboCop failed!
https://travis-ci.org/theforeman/foreman_maintain/jobs/293000847
https://travis-ci.org/theforeman/foreman_maintain/jobs/293001743
There was a problem hiding this comment.
Have reported this to rubocop/rubocop#4940
swapab
force-pushed
the
21446-rubocop-0_51_0
branch
4 times, most recently
from
e027487
to
bbdfc87
Compare
swapab
force-pushed
the
21446-rubocop-0_51_0
branch
from
bbdfc87
to
b292722
Compare
|
Ok, int that case, let's disable it globally for now, until the issue gets resolved in rubocop |
swapab
force-pushed
the
21446-rubocop-0_51_0
branch
from
b292722
to
9b83ca1
Compare
|
Thanks @swapab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.