Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22149 - handle ONLY param in katello-service for sat 6.1 #136

Merged
merged 1 commit into from Jan 11, 2018
Merged

Fixes #22149 - handle ONLY param in katello-service for sat 6.1 #136

merged 1 commit into from Jan 11, 2018

Conversation

kgaikwad
Copy link
Member

@kgaikwad kgaikwad commented Jan 8, 2018

No description provided.

iNecas
iNecas suggested changes Jan 8, 2018
View reviewed changes
Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that the :only paremter is very useful going forward, and losing it for compatibility with Sat 6.1 is quite a big loss.

What about implementing the --only parameter as --exclude set to service_list - @only and doing it just in KatelloService feature, leaving the rest as it was before. We also might do that just in case of satellite < 6.1. What do you think?

@kgaikwad
Copy link
Member Author

kgaikwad commented Jan 9, 2018

@iNecas ,
Thank you for giving me pointer towards this.
Yes, completely agree with your opinion.
I will check and modify the code as per your comment.

@kgaikwad kgaikwad force-pushed the 22149_katello_services_only_optn_absent_in_sat61 branch from d3c6a29 to c25d401 Compare January 10, 2018 10:19
@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for c25d401 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@kgaikwad kgaikwad force-pushed the 22149_katello_services_only_optn_absent_in_sat61 branch from c25d401 to faca492 Compare January 10, 2018 10:27
@kgaikwad
Copy link
Member Author

@iNecas & @swapab ,
Done with modifications. PR ready for review.

@kgaikwad kgaikwad changed the title Fixes #22149 - removed ONLY param katello-service procedures Fixes #22149 - handle ONLY param in katello-service for sat 6.1 Jan 10, 2018
@iNecas
Copy link
Member

iNecas commented Jan 11, 2018

Tested and works well. Thanks @kgaikwad

@iNecas iNecas merged commit cda046b into theforeman:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNecas iNecas iNecas approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kgaikwad @theforeman-bot @iNecas