Fixes #22436: Fix some nitpicks #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaikwad
suggested changes
Jan 28, 2018
There was a problem hiding this comment.
@ntkathole,
Thank you for creating PR.
Added one inline comment. Please check and fix test.
| @@ -209,7 +209,7 @@ def confirm_scenario(scenario) | |||
| response = reporter.ask_decision(<<-MESSAGE.strip_heredoc.strip) | |||
| The pre-upgrade checks indicate that the system is ready for upgrade. | |||
| It's recommended to perform a backup at this stage. | |||
| Confirm to continue with the the modification part of the upgrade | |||
| Confirm to continue with the modification part of the upgrade | |||
There was a problem hiding this comment.
One of test is failing for this change in upgrade_runner_test.rb file. Please fix failing test.
ntkathole
force-pushed
the
minor-fixes
branch
from
450b8aa
to
237ce06
Compare
|
@kgaikwad Thank you. Updated. |
kgaikwad
approved these changes
Jan 29, 2018
|
Thanks @ntkathole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.