Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22976, #22977 - foreman-installer doesnt take --upgrade #162

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

sean797
Copy link
Member

@sean797 sean797 commented Mar 21, 2018

and katello-installer doesn't exist anymore

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • b3f44dd must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for b3f44dd exceeds 65 characters
  • commit message for b3f44dd is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Mar 21, 2018

Don't forget, that this is meant to be used with katello upstream, where katello-installer is still pretty common and active https://github.com/Katello/katello-installer. A redmine issue against http://projects.theforeman.org/projects/foreman-maintain/issues/new is also appreciated.

@iNecas
Copy link
Member

iNecas commented Mar 21, 2018

Scratch that, I was too fast with the comment: on the other hand, since we still target satellite 6.1 (at least in theory), we should still keep katello-installer option there.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 0d6cfba exceeds 65 characters
  • commit message for 0d6cfba is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@sean797 sean797 changed the title foreman-installer doesnt take --upgrade Fixes #22976, #22977 foreman-installer doesnt take --upgrade Mar 21, 2018
@sean797 sean797 changed the title Fixes #22976, #22977 foreman-installer doesnt take --upgrade Fixes #22976, #22977 - foreman-installer doesnt take --upgrade Mar 21, 2018
@sean797
Copy link
Member Author

sean797 commented Mar 21, 2018

Hows that @iNecas ? Thanks!

@iNecas
Copy link
Member

iNecas commented Mar 22, 2018

Much better, ready for testing @ntkathole

@iNecas
Copy link
Member

iNecas commented Mar 22, 2018

Well, ready for testing after rebase, as there is a conflict at the moment

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for a2cb6e0 exceeds 65 characters
  • commit message for a2cb6e0 is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

and katello no longers uses katello-installer
@sean797
Copy link
Member Author

sean797 commented Mar 22, 2018

rebased!

@ntkathole
Copy link
Contributor

ACK 👍

D, [2018-03-22 13:11:26-0400 #15527] DEBUG -- : Running command rpm -q 'satellite-installer' --queryformat="%{VERSION}" with stdin nil
D, [2018-03-22 13:11:26-0400 #15527] DEBUG -- : output of the command:
 6.2.0.13
D, [2018-03-22 13:11:26-0400 #15527] DEBUG -- : Running command LANG=en_US.utf-8 satellite-installer --upgrade with stdin nil
D, [2018-03-22 13:16:21-0400 #15527] DEBUG -- : output of the command:
 Script started on Thu 22 Mar 2018 01:11:26 PM EDT
Upgrading...
Upgrade Step: stop_services...
D, [2018-03-22 13:17:05-0400 #124352] DEBUG -- : Running command rpm -q 'satellite-installer' --queryformat="%{VERSION}" with stdin nil
D, [2018-03-22 13:17:05-0400 #124352] DEBUG -- : output of the command:
 6.3.0.12
D, [2018-03-22 13:17:05-0400 #124352] DEBUG -- : Running command LANG=en_US.utf-8 satellite-installer --upgrade with stdin nil
D, [2018-03-22 13:20:39-0400 #124352] DEBUG -- : output of the command:
 Script started on Thu 22 Mar 2018 01:17:05 PM EDT
Upgrading, to monitor the progress on all related services, please do:
  foreman-tail | tee upgrade-$(date +%Y-%m-%d-%H%M).log
D, [2018-03-22 13:20:14-0400 #10613] DEBUG -- : Running command rpm -q 'katello-installer' --queryformat="%{VERSION}" with stdin nil
D, [2018-03-22 13:20:14-0400 #10613] DEBUG -- : output of the command:
 2.3.25
D, [2018-03-22 13:20:14-0400 #10613] DEBUG -- : Running command LANG=en_US.utf-8 katello-installer --upgrade with stdin nil
D, [2018-03-22 13:35:43-0400 #10613] DEBUG -- : output of the command:
 Script started on Thu 22 Mar 2018 01:20:14 PM EDT
Upgrading...
Upgrade Step: stop_services...

@iNecas
Copy link
Member

iNecas commented Mar 23, 2018

Thanks @sean797 and @ntkathole

@iNecas iNecas merged commit e56255a into theforeman:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants