New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #23498 - run with mongo 3.4 from scl #179
Conversation
ACK codewise. alda519 mind testing to check it fixes the issue for you? |
Sure. |
@alda519 that is my plan. I'll try to guess version from the running server with fallback to the installed packages (aka available_core) as you suggest. The only issue to solve is that there could be more mongo versions installed and we can not tell what is used when the service is down. I'll update this PR with the fix. |
@alda519 could you please re-test? |
Yup, now it works when mongo is down. Perfect. |
One last thing: rubocop is not happy. Going to merge after that's resolved. |
To get version of the db server (may be remote) we assume the 'mongo' command is always available. If there is only mongo from SCL present the mongo client has to be called from within a scl. With current state of things it is safe to assume there is at least some mongo client installed. For the future We will need to figure out how to install a correct version of the client.
@iNecas rubocop seems satisfied now. |
Thanks @mbacovsky |
To get version of the db server (may be remote) we assume the
'mongo' command is always available. If there is only mongo from SCL
present the mongo client has to be called from within a scl.
With current state of things it is safe to assume there is at least
some mongo client installed. For the future We will need to figure out
how to install a correct version of the client.