Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23152 - validating repo error #194

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

upadhyeammit
Copy link
Contributor

This fixes display issue of subscription-manager error message which is being displayed along with foreman-maintain check message.

@theforeman-bot
Copy link
Member

Issues: #23152

@kgaikwad
Copy link
Member

@upadhyeammit,
Rubocop is not happy!

@upadhyeammit
Copy link
Contributor Author

@kgaikwad Its not happy because of #193 modifications, should I make those rubocop changes in this PR itself ?

@kgaikwad
Copy link
Member

@upadhyeammit,
ohh.. ok!
Then it would be good to have those changes in different PR instead of this PR.

@kgaikwad
Copy link
Member

No any changes required codewise.
@ntkathole, please have a look.

@ntkathole
Copy link
Contributor

@upadhyeammit i can still see same behaviour as mention in issue. Those statements are displayed in same line

Validate availability of repositories: 
- Validating availability of repositories for 6.4Consumer profile "f3b988f9-28f2-4230-af4a-fe4cf05143ca" has been deleted from the server. You can use command clean or unregister to remove local profile.
| Some repositories missing, calling `subscription-manager refresh`   [FAIL]    
Failed executing subscription-manager refresh, exit status 70:
 Unit f3b988f9-28f2-4230-af4a-fe4cf05143ca has been deleted
--------------------------------------------------------------------------------

@ntkathole
Copy link
Contributor

Might be i was missing something...this works fine


Validate availability of repositories: 
/ Some repositories missing, calling `subscription-manager refresh`   [FAIL]    
Failed executing subscription-manager refresh, exit status 70:
 Unit c0fb3f2c-3967-4982-92d5-f553f88813c0 has been deleted
--------------------------------------------------------------------------------

Copy link
Contributor

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mbacovsky
Copy link
Member

👍 @upadhyeammit, thanks!

@mbacovsky mbacovsky merged commit a4ae48c into theforeman:master Aug 17, 2018
@upadhyeammit upadhyeammit deleted the bz-1561140 branch December 3, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants