Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #23984 - resolved rubocop warning #195

Merged
merged 1 commit into from Jun 22, 2018

Conversation

kgaikwad
Copy link
Member

No description provided.

@kgaikwad kgaikwad requested a review from iNecas June 21, 2018 11:40
@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • cd5c028 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Jun 21, 2018

Please add Refs #23984 to the commit message, as that's were the change was introduced, probably not that important here, but in general, it helps in case we would need to do some cherry-picking later.

@kgaikwad kgaikwad changed the title Fixes - resolved rubocop warning Refs #23984 - resolved rubocop warning Jun 21, 2018
@kgaikwad
Copy link
Member Author

@iNecas,
done!!

@iNecas iNecas merged commit 7f91538 into theforeman:master Jun 22, 2018
@iNecas
Copy link
Member

iNecas commented Jun 22, 2018

Thanks @kgaikwad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants