Fixes #24101 - execute confine for puppet3 check for sat 6.4 #197
Conversation
|
Issues: #24101 |
| @@ -21,8 +21,8 @@ class PreUpgradeCheck < Abstract | |||
| def compose | |||
| add_steps(find_checks(:default)) | |||
| add_steps(find_checks(:pre_upgrade)) | |||
| add_steps(find_checks(:puppet_upgrade_guide)) | |||
There was a problem hiding this comment.
I think, this check should be before validating repositories so moved line above repo. validate check.
There was a problem hiding this comment.
If upgrade path goes from sat 6.4 to sat 6.4.z, never like from sat 6.3 to sat 6.4.z then we don't need it in sat 6.4.z scenario. But here, it is needed for sat 6.4.
There was a problem hiding this comment.
@iNecas,
Still I think, it may happen that upgrade path from sat 6.3.z to sat 6.4.z so would like to know your suggestion on this?
There was a problem hiding this comment.
I think it should probably not be in 6.4.z, but only in 6.4 (upgrading from 6.3)
There was a problem hiding this comment.
Thank you @iNecas.
Updated PR with this modification.
kgaikwad
force-pushed
the
24101_fix_puppet_check_to_scenarios
branch
from
761cf3a
to
3290ff9
Compare
|
Thanks @kgaikwad and @ntkathole |
No description provided.