Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24789 - Recognize services on capsule #208

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

mbacovsky
Copy link
Member

Moving services to correct features. qpidd and qdrouterd belongs to
Pulp. httpd is dependency of goth Foreman and Pulp so it was added to
both. gofer is a feature of a client registered to Katello (which is
orthogonal to server/proxy) and was moved to separate gofer feature.

Moving services to correct features. qpidd and qdrouterd belongs to
Pulp. httpd is dependency of goth Foreman and Pulp so it was added to
both. gofer is a feature of a client registered to Katello (which is
orthogonal to server/proxy) and was moved to separate gofer feature.
@theforeman-bot
Copy link
Member

Issues: #24789

Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, @ntkathole mind testing?

@ntkathole
Copy link
Contributor

@mbacovsky found an new issue while testing this PR,

# ./bin/foreman-maintain service restart
Running preparation steps required to run the next scenarios
================================================================================
Setup hammer:                                                         [FAIL]
undefined method `[]' for nil:NilClass
--------------------------------------------------------------------------------

Do you want new issue for this?

@ntkathole
Copy link
Contributor

@mbacovsky
Copy link
Member Author

@ntkathole, thanks for testing this. And yes, I found a series of (about six) issues while testing this. This one is tracked in https://projects.theforeman.org/issues/24793. I guess it does not prevent this PR from merging, right? I'll sum up my other findings in an email to discuss the consequences possible actions.

@mbacovsky
Copy link
Member Author

@ntkathole, I'll link the BZ with the upstream issue

@iNecas iNecas merged commit aef49e0 into theforeman:master Sep 4, 2018
@iNecas
Copy link
Member

iNecas commented Sep 4, 2018

Thanks @mbacovsky and @ntkathole

@mbacovsky
Copy link
Member Author

@ntkathole, after some investigation this should be tracked as two separate issues. Interesting I was not able to reproduce it in the server. Do you still have the setup? Could you confirm if this PR is good to go?

@ntkathole
Copy link
Contributor

I mistakenly check both times on capsules. That issue is not reproducible on sat server.
ACK. Looks good!

@mbacovsky
Copy link
Member Author

@ntkathole I linked the BZ with the upstream issue as planed originally.
Thanks @ntkathole, @iNecas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants