Fixes #24891 - return non-zero exit code when services are down #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24891 |
mbacovsky
force-pushed
the
24891_service_status
branch
from
c33a5f7
to
53c97fb
Compare
kgaikwad
suggested changes
Sep 19, 2018
There was a problem hiding this comment.
Thank you @mbacovsky,
Please check a inline comment related to typo correction.
definitions/features/service.rb
Outdated
| status | ||
| end | ||
|
|
||
| def alowed_action?(action) |
There was a problem hiding this comment.
Correct the typo it should be allowed_action?
mbacovsky
changed the title
mbacovsky
force-pushed
the
24891_service_status
branch
from
53c97fb
to
19b955b
Compare
Sorting services also by name to make removing duplicites more efficient.
mbacovsky
force-pushed
the
24891_service_status
branch
from
19b955b
to
e948b8c
Compare
|
@kgaikwad thanks for review, updated |
iNecas
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Tested and works well. The info about --whitelist="service-status" is a bit strange, but I agree this should be tacked in separate PR. @ntkathole do you want to give this a try as well before merge?
|
Thanks @mbacovsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.