Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25012 - migrate Pulp using new services #222

Merged
merged 1 commit into from Sep 24, 2018
Merged

Fixes #25012 - migrate Pulp using new services #222

merged 1 commit into from Sep 24, 2018

Conversation

mbacovsky
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Issues: #25012

kgaikwad
kgaikwad reviewed Sep 24, 2018
View reviewed changes
Copy link
Member

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mbacovsky.
Code wise looks good to me.

@iNecas
Copy link
Member

iNecas commented Sep 24, 2018

ACK: @ntkathole mind blessing from QE perspective?

ntkathole
ntkathole approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍 Works fine!

@iNecas
Copy link
Member

iNecas commented Sep 24, 2018

Thanks @mbacovsky and @ntkathole

@iNecas iNecas merged commit dbe1e0c into theforeman:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgaikwad kgaikwad kgaikwad left review comments

@ntkathole ntkathole ntkathole approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbacovsky @theforeman-bot @iNecas @kgaikwad @ntkathole