Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26872 - Adds postgres config file to backup #264

Merged
merged 1 commit into from May 28, 2019

Conversation

johnpmitsch
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #26872

@jturel
Copy link
Contributor

jturel commented May 28, 2019

Before this change:

[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-24-33]# pwd
/var/tmp/sat_bak/satellite-backup-2019-05-28-15-24-33
[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-24-33]# find ./ -name postgresql.conf
<no results>

after change:

[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-27-55]# pwd
/var/tmp/sat_bak/satellite-backup-2019-05-28-15-27-55
[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-27-55]# find ./ -name postgresql.conf
./var/lib/pgsql/data/postgresql.conf
[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-27-55]# diff ./var/lib/pgsql/data/postgresql.conf /var/lib/pgsql/data/postgresql.conf
[root@sat-6-5-qa-rhel7 satellite-backup-2019-05-28-15-27-55]# 

Looks good!

Copy link
Contributor

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK thanks @johnpmitsch

@johnpmitsch
Copy link
Contributor Author

I can merge, but could @mbacovsky @iNecas or @kgaikwad confirm I've put things in the right place?

Copy link
Member

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @johnpmitsch, looks legitimate to me! 👍

@johnpmitsch johnpmitsch merged commit 632c332 into theforeman:master May 28, 2019
@johnpmitsch johnpmitsch deleted the addpgsqlfile branch May 28, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants