Fixes #27122 - Sat 6.6.z scenario #270
Conversation
|
Issues: #27122 |
There was a problem hiding this comment.
Thank you @upadhyeammit.
Overall looks good to me except one inline comment.
| end | ||
|
|
||
| def compose | ||
| add_step(Procedures::Service::Start.new) |
There was a problem hiding this comment.
There is difference in steps of post-migrations phase from scenario 6.6 to 6.6.z.
Below steps are missing which might be needed for upgrading 6.5 to 6.6.z.
add_step(Procedures::ForemanDocker::RemoveForemanDocker.new)
add_step(Procedures::Foreman::ApipieCache.new)
@xprazak2, please confirm.
There was a problem hiding this comment.
Correct, if someone goes from 6.5 directly to 6.6.z, docker should be dropped as well.
There was a problem hiding this comment.
+1. in that case, we can skip those steps.
There was a problem hiding this comment.
@upadhyeammit @kgaikwad Sorry for replying late here. But just a scenario came in mind. Let's consider what if user is performing upgrade from 6.5 to 6.6 and after yum update, somehow installer failed in first try and user wants to retry upgrade. At this point we will have 6.6.z target version and considering installer completed successfully in second run, but, this will not remove docker as we have not defined this steps for 6.6.z scenario. What do you think?
There was a problem hiding this comment.
The current behavior should remember that the upgrade from 6.5 to 6.6 is in progress, until it finishes successfully, so in this case, it would not have 6.6.z even though there are already packages from 6.6 installed.
There was a problem hiding this comment.
yes, true. It may affect only when somehow data.yml is removed/changed.
There was a problem hiding this comment.
Thanks @ntkathole. To avoid this case, merging PR-272 which will add docker removal steps to 6.6.z scenario.
If user tries to do upgrade for 6.6.z after successful 6.6 upgrade, nothing to worry about it as Docker removal procedure has condition which verifies presence of docker_package before proceeding further.
|
@iNecas, @jameerpathan111, |
@kgaikwad It is fine with me. |
|
@iNecas no more comments from me |
|
Thank you @upadhyeammit |
This adds Satellite 6.6.z upgrade scenario.