Fixes #28281 - no spinner on non-tty output

[lzap]

When the tool is executed with redirected output (to a pipe or a file) the spinner thing makes thing terrible and unreadable. The process should detect if it's running a tty and then avoid spinning (e.g. when executed from cron).

Reproducer:

foreman-maintain service status > /tmp/test.log

See the ^M characeters in the log file. If the action takes a lot of time (e.g. restart) there will be a lots of these.

[theforeman-bot]

Issues: #28281

[mbacovsky]

@lzap thanks for the patch. LGTM!
@jameerpathan111, could you please confirm the suggested change does not have any unwanted effect in our automation?

[jameerpathan111]

@lzap thanks for the patch. LGTM!
@jameerpathan111, could you please confirm the suggested change does not have any unwanted effect in our automation?

Sorry for late reply, I will look into this.

[jameerpathan111]

@mbacovsky @lzap I can still see the ^M characeters in the test.log file
I have run foreman-maintain service status > /tmp/test.log.

[lzap]

This patch does not remove all of them, just those which were generated via the spinner. So many of them. Can you paste the output tho?

[kgaikwad]

This patch does not remove all of them, just those which were generated via the spinner. So many of them. Can you paste the output tho?
@jameerpathan111, could you please share the output here?

[jameerpathan111]

@kgaikwad
Attaching the output of foreman-maintain service status > /tmp/test.log using this PR.
fm_pr_291.log

[lzap]

The text looks quite readable now, I mean there are few leftovers but it's not polluted with ^M^M^M^M.

I don't see a reason why not to merge it, unless it breaks something in your tests.

[jameerpathan111]

The text looks quite readable now, I mean there are few leftovers but it's not polluted with ^M^M^M^M.
I don't see a reason why not to merge it, unless it breaks something in your tests.

yeah, it doesn't break anything. We can ignore few of ^M characters.

[kgaikwad]

Sorry for the delay @lzap. Merging this patch.

[kgaikwad]

Thank you @lzap and @jameerpathan111.

[jameerpathan111]

Note: @lzap @kgaikwad with and without pr change, it is showing almost same ^M chars. Just few of them are removed. :(

[kgaikwad]

@jameerpathan111 - As long as no any unwanted failure in automation or tests, I guess that's fine.