-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #28462 - Clean up qpid jrnl on restore #296
Conversation
Issues: #28462 |
Test failure looks unrelated |
I was wrong with this workaround - we can not delete files like |
@chris1984 if we are going to drop #253 then I think this workaround is not required. |
@upadhyeammit I am fine with dropping it, but lets first wait and hear back from @pmoravec to see if any more action is needed. I would hate to close it if there is more action needed, if the other pr solves the issue then we can close this one. |
@pmoravec here is the updated pr. @upadhyeammit it looks like we still need this after talking to Pavel today in #satellite6 |
This preventive deletion prevents https://bugzilla.redhat.com/show_bug.cgi?id=1781386 on the given reproducer. Worth confirming with @pkubatrh (a libdb maintainer) if the deletion cant have a side effect. |
OK I got reply that deleting those files is safe, as they contain just runtime environment info that will be regenerated after the start-up. |
Working on testing this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1780727 I had to use this patch and without it qpid didnt start up causing the clone to fail. So another test showing this works. |
@kgaikwad can this get a merge please? |
Thanks @chris1984! |
This PR addresses an issue with restoring a satellite and qpid starting but not listening due to the jrnl files being corrupted.
I reached out to @pmoravec and this is the work-around for BZ 1781386
Let me know if that looks correct @pmoravec I tested it here on a 6.6 satellite and the restore worked correctly and qpid started up correctly.