New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #30140 - Check should only run if dhcp provider is 'dhcp_isc' #364
Fixes #30140 - Check should only run if dhcp provider is 'dhcp_isc' #364
Conversation
Issues: #30140 |
@@ -9,15 +9,16 @@ class VerifyDhcpConfigSyntax < ForemanMaintain::Check | |||
end | |||
|
|||
def run | |||
if feature(:foreman_proxy).features.include?('dhcp') | |||
if feature(:foreman_proxy).features.include?('dhcp') && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move this dhcp
feature condition in confine block?
any updates on this? |
@kgaikwad I have shifted the condition to confine block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thank you @patilsuraj767! |
No description provided.