Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32104 - Use threads to run action on services #458

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

upadhyeammit
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #32104

@upadhyeammit
Copy link
Contributor Author

@jlsherrill @kgaikwad request to review.
@swadeley request to test changes.
Thank You!

Copy link
Contributor

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

~]# cd /usr/share/gems/gems/foreman_maintain-0.7.7/
foreman_maintain-0.7.7]# git init
foreman_maintain-0.7.7]# git add .
foreman_maintain-0.7.7]# git commit -m init
foreman_maintain-0.7.7]# wget https://github.com/theforeman/foreman_maintain/pull/458.patch
foreman_maintain-0.7.7]# git apply 458.patch
foreman_maintain-0.7.7]# foreman-maintain service restart
foreman_maintain-0.7.7]# hammer ping

pulp3:            
    Status:          ok

ACK

@swadeley
Copy link
Contributor

Hello

foreman_maintain-0.7.7]# systemctl status pulpcore-worker@*

shows six workers running

Copy link
Contributor

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK thanks @upadhyeammit !!! plz to merge :)

Copy link
Member

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Had a query as you haven't added abort_on_exception=true. When any thread terminates with an exception, value will raise this exception and which resolves my query :)

@upadhyeammit upadhyeammit merged commit 0b682bc into theforeman:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants