-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #32104 - Use threads to run action on services #458
Fixes #32104 - Use threads to run action on services #458
Conversation
Issues: #32104 |
@jlsherrill @kgaikwad request to review. |
77b6c7a
to
ddcc706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
~]# cd /usr/share/gems/gems/foreman_maintain-0.7.7/
foreman_maintain-0.7.7]# git init
foreman_maintain-0.7.7]# git add .
foreman_maintain-0.7.7]# git commit -m init
foreman_maintain-0.7.7]# wget https://github.com/theforeman/foreman_maintain/pull/458.patch
foreman_maintain-0.7.7]# git apply 458.patch
foreman_maintain-0.7.7]# foreman-maintain service restart
foreman_maintain-0.7.7]# hammer ping
pulp3:
Status: ok
ACK
Hello
shows six workers running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK thanks @upadhyeammit !!! plz to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Had a query as you haven't added abort_on_exception=true
. When any thread terminates with an exception, value
will raise this exception and which resolves my query :)
942064e
to
65aba13
Compare
No description provided.