Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup and restore for Debian #620

Merged
merged 23 commits into from
Jun 29, 2022
Merged

Backup and restore for Debian #620

merged 23 commits into from
Jun 29, 2022

Conversation

upadhyeammit
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #34203

@upadhyeammit upadhyeammit requested a review from evgeni June 2, 2022 14:08
ehelms
ehelms approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, from a code perspective LGTM

evgeni
evgeni reviewed Jun 2, 2022
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review, but some food for thought :)

definitions/procedures/selinux/set_file_security.rb Outdated Show resolved Hide resolved
lib/foreman_maintain/concerns/base_database.rb Outdated Show resolved Hide resolved
lib/foreman_maintain/concerns/firewall/maintenance_mode.rb Outdated Show resolved Hide resolved
@upadhyeammit
Copy link
Contributor Author

@evgeni I can't find path or version of Postgresql stored in installer answers. When you say 'pkg and user' does it mean ask user for the version being used for Foreman installation?

@evgeni
Copy link
Member

evgeni commented Jun 3, 2022

"extract from pkg and USE it" damn typo 🫣

Essentially, find all packages of the form "postgresql-N" and backup all of the matching paths.

@upadhyeammit
Fixes #35007 - update metadata and os_facts concern for debian
4b1e250
@upadhyeammit
Fixes #35008 - run restorecon only if cmd is available
5513a86
@upadhyeammit
Fixes #35009 - Update base_database concern for Debian pgsql dir
9986440
@upadhyeammit
Refs #34195 - correct installed? method of apt pkg manager
11dfeed
@upadhyeammit
Refs #35007 - remove unused rpms method
61ff067
@upadhyeammit
Fixes #35010 - update the pgsql config path for Debian
4f1efe6
@upadhyeammit
Refs #35007 - use rpms or debs while saving metadata and make cops happy
85ba9bd
@upadhyeammit
Refs #34195 - correctly query installed packages
464d6a1
@upadhyeammit
Fixes #35011 - make maintenance mode procedure to ask about installin…
0caffce 
…g nftables or iptables
@upadhyeammit
Refs #35008 - depend on /sys/fs/selinux to run restorecon
0d142fb
@upadhyeammit
Refs #35011 - use OS version to decide using nftables
95a2a37
@upadhyeammit
Fixes #35021 - backup and restore all Postgresql dirs on Debian
3f51f0e
@upadhyeammit
Fixes #35036 - backup and restore config dirs of Debian
b61733c
@upadhyeammit
Refs #34195 - refactor apt installed? method
9b1a9ee
@upadhyeammit
Refs #35128 - Refactor the base_database concern
ec6e0a1
@upadhyeammit
Refs #35021 - refactor Postgresql data backup on Debian
46bf2b7
@upadhyeammit
Fixes #35129 - Fix backup tests for Ruby 3.0
5edadb7
@upadhyeammit
Refs #35128 - Refactor config_files and pg_data_dir
42d7b81
@upadhyeammit
Refs #35011 - use nftables for Ubuntu 22 and onward
4355ca5
@upadhyeammit
Fixes #35094 - identify debian and ubuntu and use it
92c0659
@upadhyeammit
Refs #35128 - Refactor config_files and foreman_db procedures
d337caf
@upadhyeammit
Refs #35007 - collect OS VERSION instead of VERSION_ID
a7afff4
@upadhyeammit
Refs #35128 - Refactor the code for backup and restore
9b900e8
@upadhyeammit
Copy link
Contributor Author

Thanks a lot @ehelms @ekohl and @evgeni for reviews! Merging this now.

@upadhyeammit upadhyeammit merged commit 86ebdff into theforeman:master Jun 29, 2022
@upadhyeammit upadhyeammit deleted the 34203 branch June 29, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni requested changes

@ehelms ehelms ehelms approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs re-review Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upadhyeammit @theforeman-bot @evgeni @ehelms @ekohl