Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35487 - add missing psql and nftables dependencies #639

Merged
merged 1 commit into from Sep 21, 2022

Conversation

upadhyeammit
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #35487

@upadhyeammit
Copy link
Contributor Author

upadhyeammit commented Sep 5, 2022

These are the dependencies I can see getting removed if I try to remove the packages. Maybe I should not care about the firewalld but considering it popularity its so much possible to have it by default installed.

And at the same time I feel the foreman-protector should actually iterate through all dependencies of whitelist packages, and should not consider it as static list only. I need to check if we do it already, if not then its worth to work for that.

Edit: I dont see we whitelist dependencies of whitelisted packages, but can we end up allowing too much to install or update? However in that case also that's what we expect to do because user will then disable the plugin and do the install!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants