Fix foreman service being enabled after disable #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional is no longer needed since having Puma as our app server for foreman. This code path introduced a bug where once foreman was disabled it would never be enabled again.
Griffin-Sullivan
approved these changes
May 17, 2023
There was a problem hiding this comment.
Followed steps in the BZ here with this build.
Result after reboot:
● foreman.service - Foreman
Loaded: loaded (/usr/lib/systemd/system/foreman.service; enabled; vendor pre>
Drop-In: /etc/systemd/system/foreman.service.d
└─installer.conf
Active: active (running) since Wed 2023-05-17 14:14:48 EDT; 2min 36s ago
Docs: https://theforeman.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional is no longer needed since having Puma as our app server for foreman. This code path introduced a bug where once foreman was disabled it would never be enabled again.