Fixes #20641 - clean the upgrade storage on upgrade finish

[iNecas]

No description provided.

[iNecas]

Tests updated

[iNecas]

@swapab mind review?

[swapab]

Just a silly question. Any reason to prefer block check over an inline check?

[iNecas]

just a personal preference. Sometimes the modifier statement can get overlooked. Probably not this case though

[swapab]

Upgrade run works like a charm.!!! @iNecas 🏆
Tested with following command:

./bin/foreman-maintain upgrade run --target-version 6.2.z --whitelist="check-old-foreman-tasks,disk-io,packages-update"

https://paste.fedoraproject.org/paste/mDfXzdtFeaXgD4qNs-3iRw (Ignore the errors. Those are system specific)

---

Cleaning also works as expected.

Command:

./bin/foreman-maintain upgrade run --target-version 6.2.z --whitelist="check-old-foreman-tasks,disk-io,packages-update,installer-upgrade"

Stripped result:

Running procedures after migrating to Satellite 6.2.z
================================================================================
turn off maintenance mode:                                            [OK]
--------------------------------------------------------------------------------
re-enable sync plans: 
/ Total 0 sync plans are now enabled.                                 [OK]      
--------------------------------------------------------------------------------


Running checks after upgrading to Satellite 6.2.z
================================================================================
check for paused tasks:                                               [OK]
--------------------------------------------------------------------------------
Check whether system is self-registered or not: 
System is not self registered                                         [OK]
--------------------------------------------------------------------------------


--------------------------------------------------------------------------------
Upgrade finished.

---

Ready to merge. ✅

[iNecas]

Thanks @swapab