Fixes #19496 - passenger recycler #89
Conversation
|
LGTM, note you have |
swapab
force-pushed
the
19496-passenger-recycler
branch
from
6b85384
to
c95656d
Compare
|
Deleted |
|
LGTM one nitpick - I realized that 5 minutes by default is too tight, we max with 4 SIGTERMs with 90 seconds delay each which is in total 6 minutes. In the worst case, another process would be spawned. I suggest to run the cron job every 15 minutes by default, can you change the cronjob and also |
swapab
force-pushed
the
19496-passenger-recycler
branch
3 times, most recently
from
655bc0e
to
44d8c3e
Compare
|
Done. @lzap Can we merge this branch into master? As I will be doing the relevant packaging changes and bump the version. |
|
Sorry for late reponse, absolutely, I havent tested this version myself tho. |
|
@iNecas Can you please review this PR once and merge accordingly? |
extras/passenger-recycler.cron
Outdated
| @@ -0,0 +1,3 @@ | |||
| # Configuration file /etc/cron.d/passenger-recycler to run passenger-recycler | |||
| # every 5 minutes. | |||
There was a problem hiding this comment.
Nitpick - it is every 15 minutes now.
bin/passenger-recycler: comply with rubocop standard
swapab
force-pushed
the
19496-passenger-recycler
branch
from
44d8c3e
to
ce682dd
Compare
swapab
force-pushed
the
19496-passenger-recycler
branch
from
ce682dd
to
3025817
Compare
|
Ok, let's get this in. I'm bumping the version to |
|
Thanks, @iNecas I'll get the packaging changes ready. |
| end | ||
|
|
||
| def debug(msg) | ||
| puts(msg) if CONFIG[:DEBUG] |
There was a problem hiding this comment.
nitpick: probably better to output to STDOUT (using warn vs puts)
@lzap, I am carrying over #78 here
Following things covered in this PR:
bin/passenger-recyclerto comply with Rubocop standards.extrasdirectory. Which can be used to reside files such as.cron, .confetc.passenger-recycler./bin/foreman-maintain advanced procedure run passenger-recyclerNext steps:
bin/passenger-recyclerto/usr/bin/extras/passenger-recyclerto/etc/cron.d/passenger-recycler.PS: I have not renamed the
passenger-recyclerscript and thinking to keep it that way.