Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to use Settings DSL #83

Merged
merged 1 commit into from Oct 26, 2022
Merged

migrate to use Settings DSL #83

merged 1 commit into from Oct 26, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 26, 2022

No description provided.

@evgeni evgeni force-pushed the settings-dsl branch 2 times, most recently from 9c23482 to 16d078f Compare October 26, 2022 07:19
@janfickler
Copy link

janfickler commented Oct 26, 2022 •
edited

i guess this is then related to that PR

#82

please push it forward. Major issue

@evgeni
Copy link
Member Author

evgeni commented Oct 26, 2022

includes #84 to see if stuff actually works

@evgeni evgeni force-pushed the settings-dsl branch 2 times, most recently from 139de3b to a1e1217 Compare October 26, 2022 09:00
ares
ares approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but I think you got it all

@evgeni evgeni mentioned this pull request Oct 26, 2022
Merged
@evgeni
Copy link
Member Author

evgeni commented Oct 26, 2022

CI still fails because it needs #85 for the Puppet Environment fix (chicken, egg)

@ekohl
Copy link
Member

ekohl commented Oct 26, 2022

I merged the others. Rebased to see if it now passes.

ekohl
ekohl approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 3.3 is still running for the PR, but push already passed.

@ekohl ekohl merged commit 021ecc2 into master Oct 26, 2022
@ekohl ekohl deleted the settings-dsl branch October 26, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ares ares ares approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@evgeni @janfickler @ekohl @ares @theforeman-bot