Fixes #33755 - Do not show errors on inline edit reopen (#512)

theforeman · Nov 19, 2021 · 67bdcfe · 67bdcfe
1 parent a53b008
commit 67bdcfe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/webpack/components/EditableInput.js b/webpack/components/EditableInput.js
@@ -49,6 +49,7 @@ const EditableInput = props => {
   const onCancel = () => {
     setInputValue(props.value);
     setEditing(false);
+    setError('');
   };
 
   const onChange = value => {

diff --git a/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesEdit.test.js b/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesEdit.test.js
@@ -172,6 +172,13 @@ describe('OvalPoliciesShow', () => {
     ).not.toBeInTheDocument();
     expect(screen.getByText(ovalPolicy.name)).toBeInTheDocument();
     expect(screen.getByText('has already been taken')).toBeInTheDocument();
+    userEvent.click(
+      screen.getByRole('button', { name: 'cancel editing name' })
+    );
+    userEvent.click(editBtn);
+    expect(
+      screen.queryByText('has already been taken')
+    ).not.toBeInTheDocument();
   });
   it('should not show edit btns when user is not allowed to edit', async () => {
     render(