Fixes #14446 - Respect STI class in taxonomy search

[shlomizadok]

Not sure whether this should go here or in core.
@ares, @ohadlevy thoughts?
Anyhow tested w/ $downstream project and works as expected.

[ohadlevy]

I would open a refactoring issue to enable this usage case, and until its added, will add the workaround here.
However, if its a oneliner change (change from self.name to self.base_name) maybe just fix it in foreman itself? (at least raise a PR to start the discussion).

(in the larger scope - maybe you don't want to use taxonomix at all).

[ohadlevy]

Also, I'm missing a test? :)

[shlomizadok]

@ohadlevy not needed since theforeman/foreman#3384 ?

[shlomizadok]

@ohadlevy - Test has been added

[ares]

LGTM, sounds as a good fix to core as well, if you open the redmine issue for it, please add a comment with link to this method so it can be tracked and removed later

[shlomizadok]

Not so keen to add to core.
Will open an issue on redmine

[ares]

Not so keen to add to core.

why? isn't this broken for Compute Resources now? Foreman::Model::Ovirt.name and Foreman::Model::Ovirt.base_class.name returns different value

[shlomizadok]

Created http://projects.theforeman.org/issues/14458

[ares]

please add a comment "# can be removed after http://projects.theforeman.org/issues/14458 is fixed"

[shlomizadok]

Added

[shlomizadok]

Closing in favor of theforeman/foreman#3389 which is now merged and was asked to be ported into 1.11