Fixes #14561 - Updating parameters for foreman_scap_client in after_save #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess that tests are failing because of Rails 4.2 incompatibilities. |
xprazak2
force-pushed
the
sc-callback-skips
branch
2 times, most recently
from
362c61b
to
eb6de75
Compare
|
[test] |
xprazak2
force-pushed
the
sc-callback-skips
branch
2 times, most recently
from
5c82b70
to
a922141
Compare
|
@ares lgtm. Please ack |
xprazak2
force-pushed
the
sc-callback-skips
branch
from
a922141
to
50549e2
Compare
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
This commit moves validations of openscap feature on proxy, its association with host and changes in class param values for foreman_scap_client into after_save callback.
xprazak2
force-pushed
the
sc-callback-skips
branch
from
50549e2
to
3753ead
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
I rebased on master |
|
Sorry it took me a while, I've tested it and it works great also when associating the proxy via hostgroup. Thanks @xprazak2, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues where #160 left off.