Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14253 - Avoid mass assignment for policy widgets #168

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

xprazak2
Copy link
Contributor

I also removed useless helper. We do not even have ForemanOpenscap::PolicyDashboard::Manager.

@shlomizadok
Copy link
Member

👍

@ares
Copy link
Member

ares commented May 20, 2016

I suppose this is required for Foreman 1.12+ only, correct?

@xprazak2
Copy link
Contributor Author

I believe this is Rails 4.2 related, there is a fix in core that made 1.11.1

@ares
Copy link
Member

ares commented Jun 21, 2016

Fixes the issue for me, thanks @xprazak2, merging.

@ares ares merged commit 5540168 into theforeman:master Jun 21, 2016
@ares
Copy link
Member

ares commented Jun 21, 2016

Ooops I missed that you've used Foreman core issue # for this PR. Next time please create separate issue under Foreman Openscap project.

@shlomizadok
Copy link
Member

Also, I believe this needs to be tagged for Foreman >= 1.12?

2016-06-21 15:13 GMT+03:00 Marek Hulán notifications@github.com:

Ooops I missed that you've used Foreman core issue # for this PR. Next
time please create separate issue under Foreman Openscap project.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#168 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAadrzysgXCNs4QWWrZfQm26S-oMVTApks5qN9VhgaJpZM4Ib-DY
.

@ares
Copy link
Member

ares commented Jun 21, 2016

I think it should be 1.11 compatible, not tested. With next release we can bump the version to 0.6 and start requiring 1.12 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants