Fixes #15476 - Improve validations for policy #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xprazak2
force-pushed
the
policy-validations
branch
2 times, most recently
from
888d476
to
bf3e712
Compare
xprazak2
force-pushed
the
policy-validations
branch
from
bf3e712
to
3279ff6
Compare
shlomizadok
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@xprazak2 will you please rebase? Thanks |
xprazak2
force-pushed
the
policy-validations
branch
from
3279ff6
to
1d12a1b
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
| elsif new_record? && !wizard_initiated? | ||
| true | ||
| else | ||
| !id.blank? |
There was a problem hiding this comment.
should be equal to persisted? I think
xprazak2
force-pushed
the
policy-validations
branch
from
1d12a1b
to
1cb96bd
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@xprazak2 - please note that tests are failing :/ |
xprazak2
force-pushed
the
policy-validations
branch
from
1cb96bd
to
58d0319
Compare
| @wizard_initiated | ||
| end | ||
|
|
||
| def update_attrs |
There was a problem hiding this comment.
update_attrs strikes me as too general name (e.g., I expected to find more attributes to update here) where this update deals only with period. Would you consider renaming this method?
|
@xprazak2 - Thank you for this improvement. Tested and it works well. I have only one nitpick regarding a method name (let me know what you thing - I may be wrong...) |
xprazak2
force-pushed
the
policy-validations
branch
from
58d0319
to
1ceea86
Compare
|
I renamed the method to |
|
Merging, Thanks a lot @xprazak2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.