Fixes #16431: Explicitly set path of PolicyApi include #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining modules with syntax `::` has unintended consequences with respect to how modules are looked up. This explicitly declares the full path to the PolicyApi module instead of relying on Ruby to attempt to automatically determine it.
|
This seems to break the controller and Foreman won't start :/ |
shlomizadok
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
This #204 should fix the issue you were seeing with Foreman starting. The two changes were unrelated to each other. |
|
@shlomizadok it does not seem to break anything for me, does rebasing of core's develop help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining modules with syntax
::has unintended consequences withrespect to how modules are looked up. This explicitly declares the
full path to the PolicyApi module instead of relying on Ruby to
attempt to automatically determine it.