Fixes #16366 - Add SCAP content validations to policy #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert p.errors[:scap_content_id].include?("can't be blank") | ||
| end | ||
|
|
||
| test "should not create policy with monthly period" do |
There was a problem hiding this comment.
Typo while copying... Will change once tests are finished
shlomizadok
force-pushed
the
fix_16366
branch
from
23d5afd
to
222b1be
Compare
|
Looks good, but there is no error message when I click 'next' without changing the dropdowns. Could you have another look please? |
shlomizadok
force-pushed
the
fix_16366
branch
from
222b1be
to
538d244
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@xprazak2 - fixed |
|
Nice. Thanks! |
|
Note: I see JSON style hashes, so if all tests pass, then our rubocop is not running. |
|
Oh, I thought it was changed (noticed it has changed in core) |
|
I knew there was a rubocop discussion, but I did not notice they actually changed it in core. It is still on in our rubocop.yaml. There was also outdated rule when I tried running Seems like we can merge this and fix rubocop separately if there are no objections. |
|
Sounds like a plan. Merging, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.