fixes #19164 - create feature even if on older rex #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 4, 2017
lib/foreman_openscap/engine.rb
Outdated
|
|
||
|
|
||
| if Gem::Version.new(ForemanRemoteExecution::VERSION) >= Gem::Version.new('1.2.3') | ||
| options.merge!(:host_action_button => true) |
There was a problem hiding this comment.
Use options[:host_action_button] = true instead of options.merge!(:host_action_button => true).
stbenjam
changed the title
|
note for myself: we'll need to cherry pick this to 0.6 branch for 1.14 |
|
Thanks @stbenjam, tested with older version of REX and it works just fine. After updating, the host_action_button is correctly set to true after re-seeding the db. Merging and will do the releases for both 1.14 and 1.15. |
|
Thanks much! I also found another problem when testing on older Foreman, the smart proxy has a 1.8.7 incompatibility, there's a PR over there theforeman/smart_proxy_openscap#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template references the feature, so it always needs to exist.