Fixes #20656 - Show better message for policy without tailoring file #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
ares
requested changes
Aug 22, 2017
There was a problem hiding this comment.
just one nit, otherwise works great
before:
{
"error": {"message":"Internal Server Error: the server was unable to finish the request. This may be caused by unavailability of some required service, incorrect API call or a server-side bug. There may be more information in the server's logs."}
}
after:
{"error":{"message":"No Tailoring file assigned for policy with id 11"}}%
| :type => 'application/xml', | ||
| :filename => @tailoring_file.original_filename | ||
| else | ||
| render(:json => { :error => { :message => "No Tailoring file assigned for policy with id #{@policy.id}" } }, :status => 404) |
There was a problem hiding this comment.
since this is no longer internal server error but rather expected response, I think the text should be extracted for translations
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I extracted the test for translations. |
ares
approved these changes
Aug 22, 2017
|
APJ |
|
Thanks @xprazak2, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.