Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21488 - Update rubocop rule names #305

Merged
merged 1 commit into from Nov 1, 2017
Merged

Conversation

xprazak2
Copy link
Contributor

and regenerate .rubocop_todo.yaml

@ares
Copy link
Member

ares commented Oct 27, 2017

The failure is most likely unrelated, I'm just curious why we replaced Enabled: false with Exclude:?

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 21b55c8 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 8190c51 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@xprazak2
Copy link
Contributor Author

xprazak2 commented Nov 1, 2017

I auto-fixed some of the rules, most of them related to spacing, indentation and layout in general.

@ares
Copy link
Member

ares commented Nov 1, 2017

Thanks @xprazak2, merging since rubocop is green locally with this.

@ares ares merged commit 69f8321 into theforeman:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants