Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24696 - use string for :class_name attributes #352

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fixes #24696 - use string for :class_name attributes #352

merged 1 commit into from
Aug 24, 2018

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Aug 23, 2018

Since Rails 5.2, passing class to :class_name is not allowed anymore.

@iNecas
Fixes #24696 - use string for :class_name attributes
acec7b5 
Since Rails 5.2, passing class to `:class_name` is not allowed anymore.
@iNecas
Copy link
Member Author

iNecas commented Aug 23, 2018

Test failures unrelated

@xprazak2 xprazak2 merged commit bae77f8 into theforeman:master Aug 24, 2018
@xprazak2
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@iNecas @xprazak2 @theforeman-bot