Fixes #18998 - UX improvements #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 9, 2019
|
Works nicely, could you add pagination for tailoring files and policies as well? |
xprazak2
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
Added, please take another look. Also we'll need to update the manual for 1.0 so that the documentation button links to something that exists |
|
APJ |
|
@ares, could you please create an issue in Redmine for the status icons that are not a part of this fix so that we do not lose track of that item? |
|
Yeah, opened as https://projects.theforeman.org/issues/26780, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #385, implemented all things besides arf report icons for status, that needs more thinking