Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30970 - Replace mount_react_component helper with react_component #467

Merged
merged 1 commit into from Aug 5, 2021

Conversation

xprazak2
Copy link
Contributor

No description provided.

@ares
Copy link
Member

ares commented Apr 22, 2021

I've tested what I could think of. This introduces one regression, if I enter the policy dashboard, the Host Breakdown Chart is not rendered. Without this patch, it shows up. Funny thing is, the dashboard widget (compliance reports breakdown) works fine.

After fixing, good to merge

@xprazak2
Copy link
Contributor Author

Should be fixed now, the cause was that the donut widget expects data with :data key in hash.

Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now, merging! Thanks @xprazak2

@ares ares merged commit 4ce4abd into theforeman:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants