Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config groups API #15

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Add config groups API #15

merged 2 commits into from
Oct 6, 2020

Conversation

shiramax
Copy link
Contributor

No description provided.

@shiramax shiramax changed the title Api Add config groups API Jul 28, 2020
@ezr-ondrej ezr-ondrej linked an issue Aug 2, 2020 that may be closed by this pull request
Extract ConfigGroup #7
Closed
@ezr-ondrej ezr-ondrej mentioned this pull request Sep 23, 2020
Merged
@ezr-ondrej ezr-ondrej added this to In progress in Extract Puppet ENC Sep 26, 2020
@ezr-ondrej
Copy link
Member

Can you rebase please? :)

ezr-ondrej
ezr-ondrej reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is quite a lot of extra code.
Apart of the commented one there are views/foreman_puppet_enc/puppetclasses/*.html templates, that probably should not be part of this PR :)

config/routes.rb Outdated Show resolved Hide resolved
lib/foreman_puppet_enc/engine.rb Outdated Show resolved Hide resolved
app/controllers/concerns/foreman_puppet_enc/controller/parameters/config_group.rb Outdated Show resolved Hide resolved
app/controllers/concerns/puppet/hosts_controller_extensions.rb Outdated Show resolved Hide resolved
ezr-ondrej
ezr-ondrej requested changes Sep 30, 2020
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the unnecessary files, could you please add the test/controllers/api/v2/config_groups_controller_test.rb here? :)

Extract Puppet ENC automation moved this from In progress to Review in progress Sep 30, 2020
ezr-ondrej
ezr-ondrej reviewed Oct 6, 2020
View reviewed changes
app/controllers/foreman_puppet_enc/api/v2/config_groups_controller.rb Outdated
module Api
module V2
class ConfigGroupsController < ::Api::V2::BaseController
include ForemanPuppetEnc::Controller::Parameters::ConfigGroup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include ForemanPuppetEnc::Controller::Parameters::ConfigGroup
include ForemanPuppetEnc::Parameters::ConfigGroup

ezr-ondrej
ezr-ondrej approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shiramax ! 👍

Extract Puppet ENC automation moved this from Review in progress to Reviewer approved Oct 6, 2020
@ezr-ondrej ezr-ondrej merged commit bd43089 into theforeman:master Oct 6, 2020
Extract Puppet ENC automation moved this from Reviewer approved to Done Oct 6, 2020
@ezr-ondrej ezr-ondrej mentioned this pull request Oct 29, 2020
Merged
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Oct 29, 2020
Fixes #31094 - Remove config groups API
2b88e52 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Oct 29, 2020
@ezr-ondrej
Fixes #31094 - drop config groups API
a49a9e1 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Nov 26, 2020
@ezr-ondrej
Fixes #31094 - drop config groups API
8bd3907 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jan 15, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
cfb61f7 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Feb 17, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
b513672 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Mar 10, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
e4ed9d9 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Mar 10, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
0dee88d 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Apr 1, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
ac8f252 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Apr 1, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
0b5793e 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Apr 14, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
9283be1 
Extracted in theforeman/foreman_puppet#15.
kamils-iRonin pushed a commit to kamils-iRonin/foreman that referenced this pull request Apr 20, 2021
@kamils-iRonin
Fixes #31094 - drop config groups API
7fe9124 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request May 6, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
441a781 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request May 17, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
02d8355 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request May 23, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
f4e7fb9 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request May 25, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
071b07e 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request May 26, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
399940b 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jun 18, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
7a3d9ba 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jun 24, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
d397a86 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jun 25, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
d1dd98b 
Extracted in theforeman/foreman_puppet#15.
kamils-iRonin pushed a commit to kamils-iRonin/foreman that referenced this pull request Jun 28, 2021
@kamils-iRonin
Fixes #31094 - drop config groups API
c9ca47f 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jun 30, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
a8be5d9 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jul 1, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
297eaa6 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jul 7, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
9936bf6 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jul 11, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
2070dce 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jul 14, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
de57d8d 
Extracted in theforeman/foreman_puppet#15.
ezr-ondrej pushed a commit to ezr-ondrej/foreman that referenced this pull request Jul 18, 2021
@ezr-ondrej
Fixes #31094 - drop config groups API
49167f4 
Extracted in theforeman/foreman_puppet#15.
tbrisker pushed a commit to theforeman/foreman that referenced this pull request Jul 19, 2021
@tbrisker
Fixes #31094 - drop config groups API
ac305f2 
Extracted in theforeman/foreman_puppet#15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezr-ondrej ezr-ondrej ezr-ondrej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Extract Puppet ENC
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract ConfigGroup
2 participants
@shiramax @ezr-ondrej