Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL fixes #166

Merged
merged 3 commits into from
Jul 20, 2021
Merged

GraphQL fixes #166

merged 3 commits into from
Jul 20, 2021

Conversation

kamils-iRonin
Copy link
Member

No description provided.

@kamils-iRonin kamils-iRonin mentioned this pull request Jul 19, 2021
Open
@timogoebel timogoebel merged commit 47ab184 into theforeman:master Jul 20, 2021
@timogoebel
Copy link
Member

Thanks!

@ezr-ondrej
Copy link
Member

Do we want to cherry-pick this? I do not agree with 2.6 version btw, it is nonexistent version :)

@kamils-iRonin
Copy link
Member Author

Do we want to cherry-pick this?

Yes, I think it should be cherry-picked.

I do not agree with 2.6 version btw, it is nonexistent version :)

Changed to 2.6 to make tests on develop pass (SETTINGS[:version].notag returned 2.6.0). I think we can set 3.0 back now.

@ezr-ondrej ezr-ondrej added this to the Version 1.0 milestone Aug 4, 2021
@ezr-ondrej
Copy link
Member

ezr-ondrej commented Aug 4, 2021 •
edited

Changed to 2.6 to make tests on develop pass (SETTINGS[:version].notag returned 2.6.0). I think we can set 3.0 back now.

Yeah, I get it, good thing it's in separate commit :) Well it's squashed, I'll remove that on cherry-pick

@ezr-ondrej
Copy link
Member

CP 1.0: 48d6ee7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timogoebel timogoebel timogoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamils-iRonin @timogoebel @ezr-ondrej