Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33203 - use global constant, not module #176

Merged
merged 2 commits into from Aug 10, 2021
Merged

Fixes #33203 - use global constant, not module #176

merged 2 commits into from Aug 10, 2021

Conversation

ezr-ondrej
Copy link
Member

No description provided.

@timogoebel
Copy link
Member

Do we want a test for this?

@ares
Copy link
Member

ares commented Aug 3, 2021

Probably, at least I can confirm it works and fixes the issue :-)

@ezr-ondrej ezr-ondrej added this to the Version 1.0 milestone Aug 4, 2021
@ezr-ondrej
Copy link
Member Author

Do we want a test for this?

We have test for the find_template

foreman_puppet/test/models/foreman_puppet/provisioning_template_test.rb

Line 40 in f9cf45e

describe '#find_template by template_combinations' do

So I've added only test, that it gets called as it should here :)

@ezr-ondrej ezr-ondrej merged commit c2028fb into theforeman:master Aug 10, 2021
@ezr-ondrej ezr-ondrej deleted the provisioning_template branch August 10, 2021 08:44
@ezr-ondrej
Copy link
Member Author

CP 1.0: f24ea13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezr-ondrej @timogoebel @ares