Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Host view permissions to search by puppetclass #341

Merged
merged 1 commit into from Feb 28, 2023
Merged

Fixes Host view permissions to search by puppetclass #341

merged 1 commit into from Feb 28, 2023

Conversation

Manisha15
Copy link
Collaborator

No description provided.

@Manisha15
Copy link
Collaborator Author

Fixes issue #315

@laugmanuel laugmanuel mentioned this pull request Feb 27, 2023
Closed
nadjaheitmann
nadjaheitmann reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@nadjaheitmann nadjaheitmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not exactly sure what the code is supposed to do, but at the first glance it looks like the code prevents users to access hosts that they are not authorized to access. If so, I suppose that this restriction should not be removed.

@Manisha15
Copy link
Collaborator Author

I am not exactly sure what the code is supposed to do, but at the first glance it looks like the code prevents users to access hosts that they are not authorized to access. If so, I suppose that this restriction should not be removed.

I have reverted the authorization permissions and now this should work. We should also add the documentation somewhere that search by puppetclass is only available for users with view_hosts role.

@Ron-Lavi
Copy link
Member

@laugmanuel can I ask you to verify the fix again?

@laugmanuel
Copy link
Member

@Ron-Lavi still works!

@nadjaheitmann nadjaheitmann merged commit 3722ec5 into theforeman:master Feb 28, 2023
@nadjaheitmann
Copy link
Collaborator

Merged, thanks @Manisha15 !

@nadjaheitmann nadjaheitmann deleted the fix_host_search_permissions branch February 28, 2023 10:55
@nadjaheitmann
Copy link
Collaborator

CP to 4.1: ab289f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadjaheitmann nadjaheitmann nadjaheitmann left review comments

@Ron-Lavi Ron-Lavi Awaiting requested review from Ron-Lavi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Manisha15 @Ron-Lavi @laugmanuel @nadjaheitmann