Rewrite GHA workflow using reusable actions #381
Conversation
| - name: Run plugin tests | ||
| if: github.event_name != 'push' | ||
| run: | | ||
| bundle exec rake test:foreman_puppet | ||
| - name: Run access permission test | ||
| if: ${{ github.event_name != 'push' }} | ||
| run: | | ||
| bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb" |
There was a problem hiding this comment.
This steps has not yet executed in the reusable action.
There was a problem hiding this comment.
Related discussion: theforeman/actions#16
| - name: Install chromedriver | ||
| uses: nanasess/setup-chromedriver@master |
There was a problem hiding this comment.
@ekohl i can't see this step execution in the reusable action, do we want to execute this one? i'm not aware of this one.
There was a problem hiding this comment.
We need a browser for the acceptance tests. I think a separate container that runs selenium together with theforeman/foreman#9952 could be an alternative. It would be best to track this by opening an issue on https://github.com/theforeman/actions or at least mention it in theforeman/actions#1
There was a problem hiding this comment.
|
@ekohl how the workflow is not getting triggered? i wonder if any checks i'm missing here :/ |
Updated GitHub Action workflow using shared Rubocop and Foreman plugin test actions.
https://github.com/theforeman/actions#rubocop
https://github.com/theforeman/actions#foreman-plugin-tests