-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #32045 - Add start-end date pickers to job wizard
- Loading branch information
Showing
13 changed files
with
337 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,28 @@ | ||
| import React, { useState } from 'react'; | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { FormGroup, Radio } from '@patternfly/react-core'; | ||
| import { translate as __ } from 'foremanReact/common/I18n'; | ||
|
|
||
| export const ScheduleType = () => { | ||
| const [isFuture, setIsFuture] = useState(false); | ||
| return ( | ||
| <FormGroup label={__('Schedule type')} fieldId="schedule-type"> | ||
| <Radio | ||
| isChecked={!isFuture} | ||
| name="schedule-type" | ||
| onChange={() => setIsFuture(false)} | ||
| id="schedule-type-now" | ||
| label={__('Execute now')} | ||
| /> | ||
| <Radio | ||
| isChecked={isFuture} | ||
| name="schedule-type" | ||
| onChange={() => setIsFuture(true)} | ||
| id="schedule-type-future" | ||
| label={__('Schedule for future execution')} | ||
| /> | ||
| </FormGroup> | ||
| ); | ||
| export const ScheduleType = ({ isFuture, setIsFuture }) => ( | ||
| <FormGroup label={__('Schedule type')} fieldId="schedule-type"> | ||
| <Radio | ||
| isChecked={!isFuture} | ||
| name="schedule-type" | ||
| onChange={() => setIsFuture(false)} | ||
| id="schedule-type-now" | ||
| label={__('Execute now')} | ||
| /> | ||
| <Radio | ||
| isChecked={isFuture} | ||
| name="schedule-type" | ||
| onChange={() => setIsFuture(true)} | ||
| id="schedule-type-future" | ||
| label={__('Schedule for future execution')} | ||
| /> | ||
| </FormGroup> | ||
| ); | ||
|
|
||
| ScheduleType.propTypes = { | ||
| isFuture: PropTypes.bool.isRequired, | ||
| setIsFuture: PropTypes.func.isRequired, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 11 additions & 9 deletions
20
webpack/JobWizard/steps/Schedule/__tests__/StartEndDates.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,34 @@ | ||
| import React from 'react'; | ||
| import * as patternfly from '@patternfly/react-core'; | ||
| import { render, fireEvent, screen } from '@testing-library/react'; | ||
| import { render, fireEvent, screen, act } from '@testing-library/react'; | ||
| import { testComponentSnapshotsWithFixtures } from '@theforeman/test'; | ||
| import { StartEndDates } from '../StartEndDates'; | ||
|
|
||
| jest.spyOn(patternfly, 'FormGroup'); | ||
| patternfly.FormGroup.mockImplementation(props => <div props={props} />); | ||
|
|
||
| const setEnds = jest.fn(); | ||
| const setIsNeverEnds = jest.fn(); | ||
| const props = { | ||
| starts: '', | ||
| setStarts: jest.fn(), | ||
| ends: 'some-end-date', | ||
| setEnds, | ||
| setIsNeverEnds, | ||
| isNeverEnds: false, | ||
| }; | ||
| const fixtures = { | ||
| renders: props, | ||
| 'renders isNeverEnds false': props, | ||
| 'renders isNeverEnds true': { ...props, isNeverEnds: true }, | ||
| }; | ||
|
|
||
| describe('StartEndDates', () => { | ||
| testComponentSnapshotsWithFixtures(StartEndDates, fixtures); | ||
| it('never ends', () => { | ||
| it('never ends', async () => { | ||
| patternfly.FormGroup.mockRestore(); | ||
| render(<StartEndDates {...props} />); | ||
| const neverEnds = screen.getByLabelText('Never ends', { | ||
| selector: 'input', | ||
| }); | ||
| fireEvent.click(neverEnds); | ||
| expect(setEnds).toBeCalledWith(''); | ||
| await act(async () => render(<StartEndDates {...props} />)); | ||
| const neverEnds = screen.getByRole('checkbox', { name: 'Never ends' }); | ||
| await act(async () => fireEvent.click(neverEnds)); | ||
| expect(setIsNeverEnds).toBeCalledWith(true); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.