Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13142 - introduce advanced flag #139

Merged
merged 1 commit into from Jan 28, 2016
Merged

Conversation

ares
Copy link
Member

@ares ares commented Jan 27, 2016

RFC, I'm not sure if some icon next to link would help or maybe move schedule selection above inputs?

@ares
Copy link
Member Author

ares commented Jan 27, 2016

invo1
invo2

@ohadlevy
Copy link
Member

ohadlevy commented Jan 27, 2016 via email

@ares
Copy link
Member Author

ares commented Jan 27, 2016

How about hiding Type of query, that's useful only for future and recurring scheduling. I'd prefer to keep scheduling visible since it's important feature and it's good for users to know about it. Also it doesn't take much space. And yeah, it looks better with icon
advanced

@ares
Copy link
Member Author

ares commented Jan 27, 2016

Latest version
full
there are too many radio buttons but advanced will be hidden most of the time I think

@stbenjam
Copy link
Member

This is such a huge improvement!! 👍 👍

I think the arrows should be different though - fa-angle-right when closed and fa-angle-down when open. I think that's how most of these work? At least that's how @dLobatog's over in #130 work for the template preview.

I don't much care just as long as we're consistent about it

@ares
Copy link
Member Author

ares commented Jan 28, 2016

I changed the icons to be consistent, please take another look.

@stbenjam
Copy link
Member

ackity ACK, works great!

@ares
Copy link
Member Author

ares commented Jan 28, 2016

Thank you, merging

ares added a commit that referenced this pull request Jan 28, 2016
Fixes #13142 - introduce advanced flag
@ares ares merged commit cb2ae98 into theforeman:master Jan 28, 2016
@ares ares deleted the fix/13142 branch January 28, 2016 16:31
MariaAga pushed a commit to MariaAga/foreman_remote_execution that referenced this pull request Sep 3, 2021
Refs #11361 - Configure retry/timeout options in settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants